refactor user details plugin interface

Disco.Models/Disco.Models.csproj

@@ -145,7 +145,6 @@
     <Compile Include="Services\Jobs\Noticeboards\IHeldDeviceItem.cs" />
     <Compile Include="Services\Messaging\Email.cs" />
     <Compile Include="Services\Messaging\EmailAttachment.cs" />
-    <Compile Include="Services\Plugins\Details\DetailsResult.cs" />
     <Compile Include="Services\Users\Contact\UserContact.cs" />
     <Compile Include="Services\Users\Contact\UserContactType.cs" />
     <Compile Include="Services\Searching\DeviceSearchResultItem.cs" />

Disco.Models/Services/Plugins/Details/DetailsResult.cs

@@ -1,42 +0,0 @@
-using Newtonsoft.Json;
-using System;
-using System.Collections.Generic;
-
-namespace Disco.Models.Services.Plugins.Details
-{
-    public class DetailsResult
-    {
-        public DateTime GatheredOn { get; private set; }
-        public DateTime ExpiresOn { get; private set; }
-        public Dictionary<string, string> Details { get; }
-
-        public bool SetExpiration(DateTime expireOn)
-        {
-            if (ExpiresOn > expireOn)
-            {
-                // only set the expiration if it is sooner
-                ExpiresOn = expireOn;
-                return true;
-            }
-            else
-            {
-                return false;
-            }
-        }
-
-        public DetailsResult()
-        {
-            GatheredOn = DateTime.Now;
-            ExpiresOn = DateTime.Now.AddDays(7);
-            Details = new Dictionary<string, string>();
-        }
-
-        [JsonConstructor]
-        public DetailsResult(DateTime gatheredOn, DateTime expiresOn, Dictionary<string, string> details)
-        {
-            GatheredOn = gatheredOn;
-            ExpiresOn = expiresOn;
-            Details = details ?? new Dictionary<string, string>();
-        }
-    }
-}

Disco.Models/UI/Device/DeviceShowModel.cs

@@ -1,7 +1,6 @@
 using Disco.Models.BI.Config;
 using Disco.Models.Services.Documents;
 using Disco.Models.Services.Jobs.JobLists;
-using Disco.Models.Services.Plugins.Details;
 using System.Collections.Generic;
 
 namespace Disco.Models.UI.Device
@@ -21,7 +20,7 @@ namespace Disco.Models.UI.Device
 
         List<Repository.DocumentTemplate> DocumentTemplates { get; set; }
         List<DocumentTemplatePackage> DocumentTemplatePackages { get; set; }
-        DetailsResult AssignedUserDetails { get; set; }
+        Dictionary<string, string> AssignedUserDetails { get; set; }
         bool HasAssignedUserPhoto { get; set; }
     }
 }

Disco.Models/UI/Job/JobShowModel.cs

@@ -1,7 +1,6 @@
 using Disco.Models.Services.Documents;
 using Disco.Models.Services.Job;
 using Disco.Models.Services.Jobs.JobLists;
-using Disco.Models.Services.Plugins.Details;
 using System;
 using System.Collections.Generic;
 
@@ -18,7 +17,7 @@ namespace Disco.Models.UI.Job
 
         LocationModes LocationMode { get; set; }
         List<JobLocationReference> LocationOptions { get; set; }
-        DetailsResult UserDetails { get; set; }
+        Dictionary<string, string> UserDetails { get; set; }
         bool HasUserPhoto { get; set; }
     }
 }

Disco.Models/UI/User/UserShowModel.cs

@@ -2,7 +2,6 @@
 using Disco.Models.Services.Authorization;
 using Disco.Models.Services.Documents;
 using Disco.Models.Services.Jobs.JobLists;
-using Disco.Models.Services.Plugins.Details;
 using System.Collections.Generic;
 
 namespace Disco.Models.UI.User
@@ -18,7 +17,7 @@ namespace Disco.Models.UI.User
         
         IAuthorizationToken AuthorizationToken { get; set; }
         IClaimNavigatorItem ClaimNavigator { get; set; }
-        DetailsResult UserDetails { get; set; }
+        Dictionary<string, string> UserDetails { get; set; }
         bool HasUserPhoto { get; set; }
     }
 }