qol: offline domain join to reuse AD computer accounts

Replaces old behaviour of deleting and creating new accounts. Now when a device has a new name, its existing account is renamed and reused.
2026-02-25 14:34:34 +11:00
parent 204d57a4a5
commit 48512fa9d1
7 changed files with 174 additions and 132 deletions
@@ -204,6 +204,29 @@ namespace Disco.Services.Interop.ActiveDirectory

        #region Actions

+        public void RenameAccount(ADDomainController writableDomainController, string newName)
+        {
+            if (IsCriticalSystemObject)
+                throw new InvalidOperationException($"This account [{DistinguishedName}] is a Critical System Active Directory Object and Disco ICT refuses to modify it");
+
+            if (!writableDomainController.IsWritable)
+                throw new InvalidOperationException($"The domain controller [{Name}] is not writable. This action (Delete Account) requires a writable domain controller.");
+
+            using (ADDirectoryEntry adEntry = writableDomainController.RetrieveDirectoryEntry(DistinguishedName))
+            {
+                var entry = adEntry.Entry;
+                entry.Properties["dNSHostName"][0] = $"{newName}.{Domain.Name}";
+                entry.Properties["sAMAccountName"][0] = $"{newName}$";
+                entry.CommitChanges();
+                entry.Rename($"CN={newName}");
+                entry.CommitChanges();
+
+                // Update Distinguished Name
+                Name = newName;
+                DistinguishedName = entry.Properties["distinguishedName"][0].ToString();
+            }
+        }
+
        public void DeleteAccount(ADDomainController WritableDomainController)
        {
            if (IsCriticalSystemObject)