jessikitty/Disco
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug Fix #61: Fix Decommission/Recommission Device

Browse Source 
Checks to ensure a device domain id is valid before interacting with AD.
This commit is contained in:
Gary Sharp committed 2014-07-14 13:04:42 +10:00
1 parent 9bfa95e263
commit 5c5e5a23a2
1 file changed
+2 -2
Download Patch File Download Diff File Expand all files Collapse all files
Disco.BI/BI/Extensions/DeviceActionExtensions.cs
+2 -2
View File
@@ -88,7 +88,7 @@ namespace Disco.BI.Extensions
d.DecommissionReason = Reason; d.DecommissionReason = Reason;
// Disable AD Account // Disable AD Account
if (d.DeviceDomainId != null) if (ActiveDirectory.IsValidDomainAccountId(d.DeviceDomainId))
{ {
var adAccount = d.ActiveDirectoryAccount(); var adAccount = d.ActiveDirectoryAccount();
if (adAccount != null && !adAccount.IsCriticalSystemObject) if (adAccount != null && !adAccount.IsCriticalSystemObject)
@@ -115,7 +115,7 @@ namespace Disco.BI.Extensions
d.DecommissionReason = null; d.DecommissionReason = null;
// Enable AD Account // Enable AD Account
if (d.DeviceDomainId != null) if (ActiveDirectory.IsValidDomainAccountId(d.DeviceDomainId))
{ {
var adAccount = d.ActiveDirectoryAccount(); var adAccount = d.ActiveDirectoryAccount();
if (adAccount != null && !adAccount.IsCriticalSystemObject) if (adAccount != null && !adAccount.IsCriticalSystemObject)