SignalR Bug Fixes & Minor UI Changes

Document Template import status and Device Enrolment status fixes.
Attachment download fixes for SignalR foreverFrame transport. Database
queries for Devices, Jobs and Users updated. Device attributes (model,
profile, batch) now shown in various places.

Disco.Web/Views/Job/JobParts/Resources.cshtml

@@ -398,12 +398,6 @@
                             success: function (d) {
                                 if (d == 'OK') {
                                     // Should be removed via Repository Notifications
-                                    //$this.hide(300).delay(300).queue(function () {
-                                    //    var $this = $(this);
-                                    //    if ($this.attr('data-mimetype').toLowerCase().indexOf('image/') == 0)
-                                    //        Shadowbox.removeCache(this);
-                                    //    $this.remove();
-                                    //});
                                 } else {
                                     alert('Unable to remove attachment: ' + d);
                                 }
@@ -468,7 +462,7 @@
 
                     e.attr('data-attachmentid', a.Id).attr('data-mimetype', a.MimeType).attr('href', '@(Url.Action(MVC.API.Job.AttachmentDownload()))/' + a.Id);
                     e.find('.icon img').attr('src', '@(Url.Action(MVC.API.Job.AttachmentThumbnail()))/' + a.Id);
-                    e.find('.comments').text(a.Comments);
+                    e.find('.comments').text(a.Description);
                     e.find('.author').text(a.Author);
                     e.find('.timestamp').text(a.TimestampFull).attr('title', a.TimestampFull).livestamp(a.TimestampUnixEpoc);
                     if (canRemove)
@@ -480,10 +474,36 @@
                     if (!quick)
                         e.show('slow');
                     if (a.MimeType.toLowerCase().indexOf('image/') == 0)
-                        e.shadowbox({ gallery: 'attachments', player: 'img', title: a.Comments });
+                        e.shadowbox({ gallery: 'attachments', player: 'img', title: a.Description });
+                    else
+                        e.click(onDownload);
                 }
             }
 
+            function onDownload() {
+                var $this = $(this);
+                var url = $this.attr('href');
+
+                if ($.connection && $.connection.hub && $.connection.hub.transport &&
+                                    $.connection.hub.transport.name == 'foreverFrame') {
+                    // SignalR active with foreverFrame transport - use popup window
+                    window.open(url, '_blank', 'height=150,width=250,location=no,menubar=no,resizable=no,scrollbars=no,status=no,toolbar=no');
+                } else {
+                    // use iFrame
+                    if (!$attachmentDownloadHost) {
+                        $attachmentDownloadHost = $('<iframe>')
+                            .attr({ 'src': url, 'title': 'Attachment Download Host' })
+                            .addClass('hidden')
+                            .appendTo('body')
+                            .contents();
+                    } else {
+                        $attachmentDownloadHost[0].location.href = url;
+                    }
+                }
+
+                return false;
+            }
+
             function removeAttachment(key) {
                 var $element = $attachmentOutput.find('a[data-attachmentid="' + key + '"]');
                 if ($element.length > 0) {
@@ -500,6 +520,8 @@
                 $this = $(this);
                 if ($this.attr('data-mimetype').toLowerCase().indexOf('image/') == 0)
                     $this.shadowbox({ gallery: 'attachments', player: 'img', title: $this.find('.comments').text() });
+                else
+                    $this.click(onDownload);
             });
 
             // Add Globally Available Functions