From f3351af9e84dfc9d50c4c2b4634d174a1176f432 Mon Sep 17 00:00:00 2001 From: Gary Sharp Date: Sun, 25 May 2014 16:21:33 +1000 Subject: [PATCH] Bug Fix: Indicate failed task if waiting If using ScheduledTaskStatus.WaitUntilFinished, only return true if the task completed successfully. --- Disco.Services/Tasks/ScheduledTaskStatus.cs | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Disco.Services/Tasks/ScheduledTaskStatus.cs b/Disco.Services/Tasks/ScheduledTaskStatus.cs index b6d6f76a..2b5fb737 100644 --- a/Disco.Services/Tasks/ScheduledTaskStatus.cs +++ b/Disco.Services/Tasks/ScheduledTaskStatus.cs @@ -363,7 +363,13 @@ namespace Disco.Services.Tasks } public bool WaitUntilFinished(TimeSpan Timeout) { - return this._tcs.Task.Wait(Timeout); + var finished = this._tcs.Task.Wait(Timeout); + + // Return false if task completed, but with an error + if (finished) + return this.TaskException == null; + else + return false; } #endregion