From fdb5d37ec830b177825e88adfa8ba4eb182acabb Mon Sep 17 00:00:00 2001 From: Gary Sharp Date: Thu, 17 Oct 2013 11:05:22 +1100 Subject: [PATCH] Fix: AuthorizationRole.Subjects can be null #24 Fixes the resulting NullReferenceException. --- Disco.Web/Areas/API/Controllers/AuthorizationRoleController.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Disco.Web/Areas/API/Controllers/AuthorizationRoleController.cs b/Disco.Web/Areas/API/Controllers/AuthorizationRoleController.cs index d332ce6e..08a3aaab 100644 --- a/Disco.Web/Areas/API/Controllers/AuthorizationRoleController.cs +++ b/Disco.Web/Areas/API/Controllers/AuthorizationRoleController.cs @@ -114,7 +114,7 @@ namespace Disco.Web.Areas.API.Controllers throw new ArgumentException(string.Format("Subjects not found: {0}", string.Join(", ", invalidSubjects)), "Subjects"); var proposedSubjects = subjects.Select(s => s.Item2.SamAccountName).OrderBy(s => s).ToArray(); - var currentSubjects = AuthorizationRole.SubjectIds.Split(','); + var currentSubjects = AuthorizationRole.SubjectIds == null ? new string[0] : AuthorizationRole.SubjectIds.Split(','); removedSubjects = currentSubjects.Except(proposedSubjects).ToArray(); addedSubjects = proposedSubjects.Except(currentSubjects).ToArray();