From 13d9ba78d111946a68a14f32482a3550cc2c73be Mon Sep 17 00:00:00 2001
From: DecDuck <declanahofmeyr@gmail.com>
Date: Mon, 20 Jan 2025 11:42:09 +1100
Subject: [PATCH] fix: assorted fixes

---
 desktop/app.vue                               | 12 ++-
 desktop/composables/downloads.ts              | 10 ++-
 desktop/composables/state-navigation.ts       |  4 +-
 desktop/pages/index.vue                       |  3 +
 desktop/pages/library/[id]/index.vue          |  2 +-
 desktop/pages/queue.vue                       | 88 +++++++++++++------
 desktop/plugins/global-error-handler.ts       |  2 +-
 desktop/src-tauri/src/database/db.rs          | 15 +++-
 .../download_manager_builder.rs               |  2 +
 .../src/download_manager/progress_object.rs   | 25 ++++--
 .../src/games/downloads/download_agent.rs     | 36 ++++----
 .../src/games/downloads/download_logic.rs     |  1 -
 desktop/src-tauri/src/games/library.rs        | 36 ++++----
 desktop/src-tauri/src/lib.rs                  | 18 ++--
 desktop/src-tauri/src/remote/auth.rs          | 13 +--
 desktop/src-tauri/src/remote/requests.rs      |  8 +-
 16 files changed, 166 insertions(+), 109 deletions(-)

diff --git a/desktop/app.vue b/desktop/app.vue
index 5616701f..b9011c6e 100644
--- a/desktop/app.vue
+++ b/desktop/app.vue
@@ -20,10 +20,18 @@ import {
 const router = useRouter();
 
 const state = useAppState();
-state.value = JSON.parse(await invoke("fetch_state"));
+try {
+  state.value = JSON.parse(await invoke("fetch_state"));
+} catch (e) {
+  console.error("failed to parse state", e);
+}
 
 router.beforeEach(async () => {
-  state.value = JSON.parse(await invoke("fetch_state"));
+  try {
+    state.value = JSON.parse(await invoke("fetch_state"));
+  } catch (e) {
+    console.error("failed to parse state", e);
+  }
 });
 
 setupHooks();
diff --git a/desktop/composables/downloads.ts b/desktop/composables/downloads.ts
index 55de7fb7..d75c46f6 100644
--- a/desktop/composables/downloads.ts
+++ b/desktop/composables/downloads.ts
@@ -2,7 +2,13 @@ import { listen } from "@tauri-apps/api/event";
 import type { DownloadableMetadata } from "~/types";
 
 export type QueueState = {
-  queue: Array<{ meta: DownloadableMetadata; status: string; progress: number | null }>;
+  queue: Array<{
+    meta: DownloadableMetadata;
+    status: string;
+    progress: number | null;
+    current: number;
+    max: number;
+  }>;
   status: string;
 };
 
@@ -25,4 +31,4 @@ listen("update_queue", (event) => {
 listen("update_stats", (event) => {
   const stats = useStatsState();
   stats.value = event.payload as StatsState;
-});
\ No newline at end of file
+});
diff --git a/desktop/composables/state-navigation.ts b/desktop/composables/state-navigation.ts
index f7a9b4b7..46d9e2b0 100644
--- a/desktop/composables/state-navigation.ts
+++ b/desktop/composables/state-navigation.ts
@@ -48,9 +48,7 @@ export function initialNavigation(state: Ref<AppState>) {
 
   switch (state.value.status) {
     case AppStatus.NotConfigured:
-      router.push({ path: "/setup" }).then(() => {
-        console.log("Pushed Setup");
-      });
+      router.push({ path: "/setup" });
       break;
     case AppStatus.SignedOut:
       router.push("/auth");
diff --git a/desktop/pages/index.vue b/desktop/pages/index.vue
index 72433aeb..52bc1df6 100644
--- a/desktop/pages/index.vue
+++ b/desktop/pages/index.vue
@@ -1,4 +1,7 @@
 <template />
 
 <script setup lang="ts">
+definePageMeta({
+    layout: false
+})
 </script>
diff --git a/desktop/pages/library/[id]/index.vue b/desktop/pages/library/[id]/index.vue
index e34c994d..539ec613 100644
--- a/desktop/pages/library/[id]/index.vue
+++ b/desktop/pages/library/[id]/index.vue
@@ -242,7 +242,7 @@
         "
         :loading="installLoading"
         type="submit"
-        class="w-full sm:w-fit"
+        class="ml-2 w-full sm:w-fit"
       >
         Install
       </LoadingButton>
diff --git a/desktop/pages/queue.vue b/desktop/pages/queue.vue
index d78967c1..b44f1794 100644
--- a/desktop/pages/queue.vue
+++ b/desktop/pages/queue.vue
@@ -1,23 +1,37 @@
 <template>
   <div class="bg-zinc-950 p-4 min-h-full space-y-4">
-    <div class="h-16 overflow-hidden relative rounded-xl flex flex-row border border-zinc-900">
+    <div
+      class="h-16 overflow-hidden relative rounded-xl flex flex-row border border-zinc-900"
+    >
       <div
-        class="bg-zinc-900 z-10 w-32 flex flex-col gap-x-2 text-blue-400 font-display items-left justify-center pl-2">
-        <span class="font-semibold">{{ formatKilobytes(stats.speed) }}</span>
-        <span v-if="stats.time > 0" class="text-sm">{{ formatTime(stats.time) }} left</span>
-
+        class="bg-zinc-900 z-10 w-32 flex flex-col gap-x-2 text-blue-400 font-display items-left justify-center pl-2"
+      >
+        <span class="font-semibold">{{ formatKilobytes(stats.speed) }}/s</span>
+        <span v-if="stats.time > 0" class="text-sm"
+          >{{ formatTime(stats.time) }} left</span
+        >
       </div>
       <div class="absolute inset-0 h-full flex flex-row items-end justify-end">
-        <div v-for="bar in speedHistory" :style="{ height: `${bar / speedMax * 100}%` }"
-          class="w-[8px] bg-blue-600/40" />
+        <div
+          v-for="bar in speedHistory"
+          :style="{ height: `${(bar / speedMax) * 100}%` }"
+          class="w-[8px] bg-blue-600/40"
+        />
       </div>
     </div>
     <draggable v-model="queue.queue" @end="onEnd">
       <template #item="{ element }: { element: (typeof queue.value.queue)[0] }">
-        <li v-if="games[element.meta.id]" :key="element.meta.id"
-          class="mb-4 bg-zinc-900 rounded-lg flex flex-row justify-between gap-x-6 py-5 px-4">
+        <li
+          v-if="games[element.meta.id]"
+          :key="element.meta.id"
+          class="mb-4 bg-zinc-900 rounded-lg flex flex-row justify-between gap-x-6 py-5 px-4"
+        >
           <div class="w-full flex items-center max-w-md gap-x-4 relative">
-            <img class="size-24 flex-none bg-zinc-800 object-cover rounded" :src="games[element.meta.id].cover" alt="" />
+            <img
+              class="size-24 flex-none bg-zinc-800 object-cover rounded"
+              :src="games[element.meta.id].cover"
+              alt=""
+            />
             <div class="min-w-0 flex-auto">
               <p class="text-xl font-semibold text-zinc-100">
                 <NuxtLink :href="`/library/${element.meta.id}`" class="">
@@ -35,47 +49,68 @@
               <p class="text-md text-zinc-500 uppercase font-display font-bold">
                 {{ element.status }}
               </p>
-              <div v-if="element.progress" class="mt-1 w-96 bg-zinc-800 rounded-lg overflow-hidden">
-                <div class="h-2 bg-blue-600" :style="{ width: `${element.progress * 100}%` }" />
+              <div
+                v-if="element.progress"
+                class="mt-1 w-96 bg-zinc-800 rounded-lg overflow-hidden"
+              >
+                <div
+                  class="h-2 bg-blue-600"
+                  :style="{ width: `${element.progress * 100}%` }"
+                />
               </div>
+              <span
+                class="mt-2 inline-flex items-center gap-x-1 text-zinc-400 text-sm font-display"
+                ><span class="text-zinc-300">{{
+                  formatKilobytes(element.current / 1000)
+                }}</span>
+                /
+                <span class="">{{ formatKilobytes(element.max / 1000) }}</span
+                ><ServerIcon class="size-5"
+              /></span>
             </div>
             <button @click="() => cancelGame(element.meta)" class="group">
-              <XMarkIcon class="transition size-8 flex-none text-zinc-600 group-hover:text-zinc-300"
-                aria-hidden="true" />
+              <XMarkIcon
+                class="transition size-8 flex-none text-zinc-600 group-hover:text-zinc-300"
+                aria-hidden="true"
+              />
             </button>
           </div>
         </li>
         <p v-else>Loading...</p>
       </template>
     </draggable>
-    <div class="text-zinc-600 uppercase font-semibold font-display w-full text-center" v-if="queue.queue.length == 0">
+    <div
+      class="text-zinc-600 uppercase font-semibold font-display w-full text-center"
+      v-if="queue.queue.length == 0"
+    >
       No items in the queue
     </div>
   </div>
 </template>
 
 <script setup lang="ts">
-import { XMarkIcon } from "@heroicons/vue/20/solid";
+import { ServerIcon, XMarkIcon } from "@heroicons/vue/20/solid";
 import { invoke } from "@tauri-apps/api/core";
 import type { DownloadableMetadata, Game, GameStatus } from "~/types";
 
 const windowWidth = ref(window.innerWidth);
-window.addEventListener('resize', (event) => {
+window.addEventListener("resize", (event) => {
   windowWidth.value = window.innerWidth;
-})
+});
 
 const queue = useQueueState();
 const stats = useStatsState();
 const speedHistory = useState<Array<number>>(() => []);
 const speedHistoryMax = computed(() => windowWidth.value / 8);
-const speedMax = computed(() => speedHistory.value.reduce((a, b) => a > b ? a : b) * 1.3);
+const speedMax = computed(
+  () => speedHistory.value.reduce((a, b) => (a > b ? a : b)) * 1.3
+);
 const previousGameId = ref<string | undefined>();
 
 const games: Ref<{
   [key: string]: { game: Game; status: Ref<GameStatus>; cover: string };
 }> = ref({});
 
-
 function resetHistoryGraph() {
   speedHistory.value = [];
   stats.value = { time: 0, speed: 0 };
@@ -97,8 +132,7 @@ function checkReset(v: QueueState) {
     return;
   }
   // If it's a different game now
-  if (currentGame != previousGameId.value
-  ) {
+  if (currentGame != previousGameId.value) {
     previousGameId.value = currentGame;
     resetHistoryGraph();
     return;
@@ -115,10 +149,12 @@ watch(stats, (v) => {
     speedHistory.value.splice(0, 1);
   }
   checkReset(queue.value);
-})
+});
 
 function loadGamesForQueue(v: typeof queue.value) {
-  for (const { meta: { id } } of v.queue) {
+  for (const {
+    meta: { id },
+  } of v.queue) {
     if (games.value[id]) return;
     (async () => {
       const gameData = await useGame(id);
@@ -152,7 +188,7 @@ function formatKilobytes(bytes: number): string {
     unitIndex++;
   }
 
-  return `${value.toFixed(1)} ${units[unitIndex]}/s`;
+  return `${value.toFixed(1)} ${units[unitIndex]}`;
 }
 
 function formatTime(seconds: number): string {
@@ -162,7 +198,7 @@ function formatTime(seconds: number): string {
 
   const minutes = Math.floor(seconds / 60);
   if (minutes < 60) {
-    return `${minutes}m ${Math.round(seconds % 60)}s`
+    return `${minutes}m ${Math.round(seconds % 60)}s`;
   }
 
   const hours = Math.floor(minutes / 60);
diff --git a/desktop/plugins/global-error-handler.ts b/desktop/plugins/global-error-handler.ts
index f9d72494..b7bcd45b 100644
--- a/desktop/plugins/global-error-handler.ts
+++ b/desktop/plugins/global-error-handler.ts
@@ -1,7 +1,7 @@
 export default defineNuxtPlugin((nuxtApp) => {
   // Also possible
   nuxtApp.hook("vue:error", (error, instance, info) => {
-    console.log(error);
+    console.error(error, info);
     const router = useRouter();
     router.replace(`/error`);
   });
diff --git a/desktop/src-tauri/src/database/db.rs b/desktop/src-tauri/src/database/db.rs
index b668d819..5140f2e6 100644
--- a/desktop/src-tauri/src/database/db.rs
+++ b/desktop/src-tauri/src/database/db.rs
@@ -1,7 +1,8 @@
 use std::{
     collections::HashMap,
     fs::{self, create_dir_all},
-    path::PathBuf,
+    hash::Hash,
+    path::{Path, PathBuf},
     sync::{LazyLock, Mutex, RwLockReadGuard, RwLockWriteGuard},
 };
 
@@ -91,10 +92,18 @@ impl Database {
         Self {
             applications: DatabaseApplications {
                 install_dirs: vec![games_base_dir.into()],
-                ..Default::default()
+                game_statuses: HashMap::new(),
+                game_versions: HashMap::new(),
+                installed_game_version: HashMap::new(),
+                transient_statuses: HashMap::new(),
             },
             prev_database,
-            ..Default::default()
+            base_url: "".to_owned(),
+            auth: None,
+            settings: Settings {
+                autostart: false,
+                max_download_threads: 4,
+            },
         }
     }
 }
diff --git a/desktop/src-tauri/src/download_manager/download_manager_builder.rs b/desktop/src-tauri/src/download_manager/download_manager_builder.rs
index 7beec146..52c014df 100644
--- a/desktop/src-tauri/src/download_manager/download_manager_builder.rs
+++ b/desktop/src-tauri/src/download_manager/download_manager_builder.rs
@@ -350,6 +350,8 @@ impl DownloadManagerBuilder {
                     meta: DownloadableMetadata::clone(key),
                     status: val.status(),
                     progress: val.progress().get_progress(),
+                    current: val.progress().sum(),
+                    max: val.progress().get_max(),
                 }
             })
             .collect();
diff --git a/desktop/src-tauri/src/download_manager/progress_object.rs b/desktop/src-tauri/src/download_manager/progress_object.rs
index f8fe7dd1..fc0907bd 100644
--- a/desktop/src-tauri/src/download_manager/progress_object.rs
+++ b/desktop/src-tauri/src/download_manager/progress_object.rs
@@ -23,7 +23,7 @@ pub struct ProgressObject {
     //last_update: Arc<RwLock<Instant>>,
     last_update_time: Arc<AtomicInstant>,
     bytes_last_update: Arc<AtomicUsize>,
-    rolling: RollingProgressWindow<256>,
+    rolling: RollingProgressWindow<250>,
 }
 
 pub struct ProgressHandle {
@@ -46,6 +46,15 @@ impl ProgressHandle {
             .fetch_add(amount, std::sync::atomic::Ordering::Relaxed);
         calculate_update(&self.progress_object);
     }
+    pub fn skip(&self, amount: usize) {
+        self.progress
+            .fetch_add(amount, std::sync::atomic::Ordering::Relaxed);
+        // Offset the bytes at last offset by this amount
+        self.progress_object
+            .bytes_last_update
+            .fetch_add(amount, Ordering::Relaxed);
+        // Dont' fire update
+    }
 }
 
 impl ProgressObject {
@@ -97,15 +106,15 @@ impl ProgressObject {
 }
 
 #[throttle(1, Duration::from_millis(20))]
-pub fn calculate_update(progress_object: &ProgressObject) {
-    let last_update_time = progress_object
+pub fn calculate_update(progress: &ProgressObject) {
+    let last_update_time = progress
         .last_update_time
         .swap(Instant::now(), Ordering::SeqCst);
     let time_since_last_update = Instant::now().duration_since(last_update_time).as_millis();
 
-    let current_bytes_downloaded = progress_object.sum();
-    let max = progress_object.get_max();
-    let bytes_at_last_update = progress_object
+    let current_bytes_downloaded = progress.sum();
+    let max = progress.get_max();
+    let bytes_at_last_update = progress
         .bytes_last_update
         .swap(current_bytes_downloaded, Ordering::Relaxed);
 
@@ -115,8 +124,8 @@ pub fn calculate_update(progress_object: &ProgressObject) {
 
     let bytes_remaining = max - current_bytes_downloaded; // bytes
 
-    progress_object.update_window(kilobytes_per_second);
-    push_update(progress_object, bytes_remaining);
+    progress.update_window(kilobytes_per_second);
+    push_update(progress, bytes_remaining);
 }
 
 #[throttle(1, Duration::from_millis(500))]
diff --git a/desktop/src-tauri/src/games/downloads/download_agent.rs b/desktop/src-tauri/src/games/downloads/download_agent.rs
index e08d7df7..21b15b63 100644
--- a/desktop/src-tauri/src/games/downloads/download_agent.rs
+++ b/desktop/src-tauri/src/games/downloads/download_agent.rs
@@ -127,25 +127,17 @@ impl GameDownloadAgent {
     }
 
     fn download_manifest(&self) -> Result<(), ApplicationDownloadError> {
-        let base_url = DB.fetch_base_url();
-        let manifest_url = base_url
-            .join(
-                format!(
-                    "/api/v1/client/game/manifest?id={}&version={}",
-                    self.id,
-                    encode(&self.version)
-                )
-                .as_str(),
-            )
-            .unwrap();
-
         let header = generate_authorization_header();
         let client = reqwest::blocking::Client::new();
-        let response = client
-            .get(manifest_url.to_string())
-            .header("Authorization", header)
-            .send()
-            .unwrap();
+        let response = make_request(
+            &client,
+            &["/api/v1/client/game/manifest"],
+            &[("id", &self.id), ("version", &self.version)],
+            |f| f.header("Authorization", header),
+        )
+        .map_err(|e| ApplicationDownloadError::Communication(e))?
+        .send()
+        .map_err(|e| ApplicationDownloadError::Communication(e.into()))?;
 
         if response.status() != 200 {
             return Err(ApplicationDownloadError::Communication(
@@ -266,9 +258,10 @@ impl GameDownloadAgent {
 
                 let progress = self.progress.get(index);
                 let progress_handle = ProgressHandle::new(progress, self.progress.clone());
+
                 // If we've done this one already, skip it
                 if self.completed_contexts.lock().unwrap().contains(&index) {
-                    progress_handle.add(context.length);
+                    progress_handle.skip(context.length);
                     continue;
                 }
 
@@ -319,8 +312,10 @@ impl GameDownloadAgent {
         // If we're not out of contexts, we're not done, so we don't fire completed
         if completed_lock_len != contexts.len() {
             info!(
-                "download agent for {} exited without completing",
-                self.id.clone()
+                "download agent for {} exited without completing ({}/{})",
+                self.id.clone(),
+                completed_lock_len,
+                contexts.len(),
             );
             self.stored_manifest
                 .set_completed_contexts(self.completed_contexts.lock().unwrap().as_slice());
@@ -385,6 +380,7 @@ impl Downloadable for GameDownloadAgent {
         .unwrap();
     }
 
+    // TODO: fix this function. It doesn't restart the download properly, nor does it reset the state properly
     fn on_incomplete(&self, app_handle: &tauri::AppHandle) {
         let meta = self.metadata();
         *self.status.lock().unwrap() = DownloadStatus::Queued;
diff --git a/desktop/src-tauri/src/games/downloads/download_logic.rs b/desktop/src-tauri/src/games/downloads/download_logic.rs
index 8e3dc1c7..70e5b7e1 100644
--- a/desktop/src-tauri/src/games/downloads/download_logic.rs
+++ b/desktop/src-tauri/src/games/downloads/download_logic.rs
@@ -133,7 +133,6 @@ pub fn download_game_chunk(
 
     if response.status() != 200 {
         let err = response.json().unwrap();
-        warn!("{:?}", err);
         return Err(ApplicationDownloadError::Communication(
             RemoteAccessError::InvalidResponse(err),
         ));
diff --git a/desktop/src-tauri/src/games/library.rs b/desktop/src-tauri/src/games/library.rs
index 2ebceb8e..f60ed1b4 100644
--- a/desktop/src-tauri/src/games/library.rs
+++ b/desktop/src-tauri/src/games/library.rs
@@ -53,6 +53,8 @@ pub struct QueueUpdateEventQueueData {
     pub meta: DownloadableMetadata,
     pub status: DownloadStatus,
     pub progress: f64,
+    pub current: usize,
+    pub max: usize,
 }
 
 #[derive(serde::Serialize, Clone)]
@@ -81,16 +83,13 @@ pub struct GameVersionOption {
 }
 
 pub fn fetch_library_logic(app: AppHandle) -> Result<Vec<Game>, RemoteAccessError> {
-    let base_url = DB.fetch_base_url();
-    let library_url = base_url.join("/api/v1/client/user/library")?;
-
     let header = generate_authorization_header();
 
     let client = reqwest::blocking::Client::new();
-    let response = client
-        .get(library_url.to_string())
-        .header("Authorization", header)
-        .send()?;
+    let response = make_request(&client, &["/api/v1/client/user/library"], &[], |f| {
+        f.header("Authorization", header)
+    })?
+    .send()?;
 
     if response.status() != 200 {
         let err = response.json().unwrap();
@@ -290,26 +289,23 @@ pub fn on_game_complete(
     app_handle: &AppHandle,
 ) -> Result<(), RemoteAccessError> {
     // Fetch game version information from remote
-    let base_url = DB.fetch_base_url();
     if meta.version.is_none() {
         return Err(RemoteAccessError::GameNotFound);
     }
 
-    let endpoint = base_url.join(
-        format!(
-            "/api/v1/client/metadata/version?id={}&version={}",
-            meta.id,
-            encode(meta.version.as_ref().unwrap())
-        )
-        .as_str(),
-    )?;
     let header = generate_authorization_header();
 
     let client = reqwest::blocking::Client::new();
-    let response = client
-        .get(endpoint.to_string())
-        .header("Authorization", header)
-        .send()?;
+    let response = make_request(
+        &client,
+        &["/api/v1/client/metadata/version"],
+        &[
+            ("id", &meta.id),
+            ("version", meta.version.as_ref().unwrap()),
+        ],
+        |f| f.header("Authorization", header),
+    )?
+    .send()?;
 
     let data: GameVersion = response.json()?;
 
diff --git a/desktop/src-tauri/src/lib.rs b/desktop/src-tauri/src/lib.rs
index 02d8197b..e0810feb 100644
--- a/desktop/src-tauri/src/lib.rs
+++ b/desktop/src-tauri/src/lib.rs
@@ -46,6 +46,7 @@ use remote::auth::{self, generate_authorization_header, recieve_handshake};
 use remote::commands::{
     auth_initiate, gen_drop_url, manual_recieve_handshake, retry_connect, sign_out, use_remote,
 };
+use remote::requests::make_request;
 use serde::{Deserialize, Serialize};
 use std::path::Path;
 use std::sync::Arc;
@@ -355,23 +356,16 @@ pub fn run() {
             Ok(())
         })
         .register_asynchronous_uri_scheme_protocol("object", move |_ctx, request, responder| {
-            let base_url = DB.fetch_base_url();
-
             // Drop leading /
             let object_id = &request.uri().path()[1..];
 
-            let object_url = base_url
-                .join("/api/v1/client/object/")
-                .unwrap()
-                .join(object_id)
-                .unwrap();
-
             let header = generate_authorization_header();
             let client: reqwest::blocking::Client = reqwest::blocking::Client::new();
-            let response = client
-                .get(object_url.to_string())
-                .header("Authorization", header)
-                .send();
+            let response = make_request(&client, &["/api/v1/client/object/", object_id], &[], |f| {
+                f.header("Authorization", header)
+            })
+            .unwrap()
+            .send();
             if response.is_err() {
                 warn!(
                     "failed to fetch object with error: {}",
diff --git a/desktop/src-tauri/src/remote/auth.rs b/desktop/src-tauri/src/remote/auth.rs
index 483be27d..d2594de5 100644
--- a/desktop/src-tauri/src/remote/auth.rs
+++ b/desktop/src-tauri/src/remote/auth.rs
@@ -15,6 +15,8 @@ use crate::{
     AppState, AppStatus, User, DB,
 };
 
+use super::requests::make_request;
+
 #[derive(Serialize)]
 #[serde(rename_all = "camelCase")]
 struct InitiateRequestBody {
@@ -67,16 +69,15 @@ pub fn generate_authorization_header() -> String {
 pub fn fetch_user() -> Result<User, RemoteAccessError> {
     let base_url = DB.fetch_base_url();
 
-    let endpoint = base_url.join("/api/v1/client/user")?;
     let header = generate_authorization_header();
 
     let client = reqwest::blocking::Client::new();
-    let response = client
-        .get(endpoint.to_string())
-        .header("Authorization", header)
-        .send()?;
+    let response = make_request(&client, &["/api/v1/client/user"], &[], |f| {
+        f.header("Authorization", header)
+    })?
+    .send()?;
     if response.status() != 200 {
-        let err: DropServerError = response.json().unwrap();
+        let err: DropServerError = response.json()?;
         warn!("{:?}", err);
 
         if err.status_message == "Nonce expired" {
diff --git a/desktop/src-tauri/src/remote/requests.rs b/desktop/src-tauri/src/remote/requests.rs
index 6990d6b4..44cdc834 100644
--- a/desktop/src-tauri/src/remote/requests.rs
+++ b/desktop/src-tauri/src/remote/requests.rs
@@ -4,17 +4,17 @@ use crate::{database::db::DatabaseImpls, error::remote_access_error::RemoteAcces
 
 pub fn make_request<T: AsRef<str>, F: FnOnce(RequestBuilder) -> RequestBuilder>(
     client: &Client,
-    endpoints: &[T],
-    params: &[(T, T)],
+    path_components: &[T],
+    query: &[(T, T)],
     f: F,
 ) -> Result<RequestBuilder, RemoteAccessError> {
     let mut base_url = DB.fetch_base_url();
-    for endpoint in endpoints {
+    for endpoint in path_components {
         base_url = base_url.join(endpoint.as_ref())?;
     }
     {
         let mut queries = base_url.query_pairs_mut();
-        for (param, val) in params {
+        for (param, val) in query {
             queries.append_pair(param.as_ref(), val.as_ref());
         }
     }