From 65a7150bd366bbc5f9db75c88b7d3686e457c37f Mon Sep 17 00:00:00 2001
From: DecDuck <declanahofmeyr@gmail.com>
Date: Mon, 30 Dec 2024 15:37:29 +1100
Subject: [PATCH] feat(process): shared child with stop command

---
 desktop/components/GameStatusButton.vue       |  7 ++--
 desktop/pages/library/[id]/index.vue          | 22 ++++++++++--
 desktop/src-tauri/Cargo.lock                  |  1 +
 desktop/src-tauri/Cargo.toml                  |  1 +
 .../src-tauri/src/process/process_commands.rs |  2 +-
 .../src-tauri/src/process/process_manager.rs  | 36 ++++++++++++-------
 6 files changed, 51 insertions(+), 18 deletions(-)

diff --git a/desktop/components/GameStatusButton.vue b/desktop/components/GameStatusButton.vue
index 65f3c7a1..d9722d29 100644
--- a/desktop/components/GameStatusButton.vue
+++ b/desktop/components/GameStatusButton.vue
@@ -57,6 +57,7 @@ const emit = defineEmits<{
   (e: "launch"): void;
   (e: "queue"): void;
   (e: "uninstall"): void;
+  (e: "kill"): void;
 }>();
 
 const showDropdown = computed(() => props.status.type === GameStatusEnum.Installed || props.status.type === GameStatusEnum.SetupRequired);
@@ -69,7 +70,7 @@ const styles: { [key in GameStatusEnum]: string } = {
   [GameStatusEnum.Installed]: "bg-green-600 text-white hover:bg-green-500 focus-visible:outline-green-600",
   [GameStatusEnum.Updating]: "bg-zinc-800 text-white hover:bg-zinc-700 focus-visible:outline-zinc-700",
   [GameStatusEnum.Uninstalling]: "bg-zinc-800 text-white hover:bg-zinc-700 focus-visible:outline-zinc-700",
-  [GameStatusEnum.Running]: "bg-zinc-800 text-white hover:bg-zinc-700 focus-visible:outline-zinc-700"
+  [GameStatusEnum.Running]: "bg-zinc-800 text-white focus-visible:outline-zinc-700"
 };
 
 const buttonNames: { [key in GameStatusEnum]: string } = {
@@ -80,7 +81,7 @@ const buttonNames: { [key in GameStatusEnum]: string } = {
   [GameStatusEnum.Installed]: "Play",
   [GameStatusEnum.Updating]: "Updating",
   [GameStatusEnum.Uninstalling]: "Uninstalling",
-  [GameStatusEnum.Running]: "Running"
+  [GameStatusEnum.Running]: "Stop"
 };
 
 const buttonIcons: { [key in GameStatusEnum]: Component } = {
@@ -102,6 +103,6 @@ const buttonActions: { [key in GameStatusEnum]: () => void } = {
   [GameStatusEnum.Installed]: () => emit("launch"),
   [GameStatusEnum.Updating]: () => emit("queue"),
   [GameStatusEnum.Uninstalling]: () => { },
-  [GameStatusEnum.Running]: () => { }
+  [GameStatusEnum.Running]: () => emit("kill")
 };
 </script>
diff --git a/desktop/pages/library/[id]/index.vue b/desktop/pages/library/[id]/index.vue
index 5d828bff..0a3513dd 100644
--- a/desktop/pages/library/[id]/index.vue
+++ b/desktop/pages/library/[id]/index.vue
@@ -23,6 +23,7 @@
           @launch="() => launch()"
           @queue="() => queue()"
           @uninstall="() => uninstall()"
+          @kill="() => kill()"
           :status="status"
         />
         <a
@@ -235,7 +236,7 @@
     </template>
     <template #buttons>
       <LoadingButton
-      @click="() => install()"
+        @click="() => install()"
         :disabled="
           !(versionOptions && versionOptions.length > 0 && !installDir)
         "
@@ -299,7 +300,7 @@ const installDirs = ref<undefined | Array<string>>();
 async function installFlow() {
   installFlowOpen.value = true;
   versionOptions.value = undefined;
-  installDirs.value = undefined
+  installDirs.value = undefined;
 
   try {
     versionOptions.value = await invoke("fetch_game_verion_options", {
@@ -357,4 +358,21 @@ async function queue() {
 async function uninstall() {
   await invoke("uninstall_game", { gameId: game.value.id });
 }
+
+async function kill() {
+  try {
+    await invoke("kill_game", { gameId: game.value.id });
+  } catch (e) {
+    createModal(
+      ModalType.Notification,
+      {
+        title: `Couldn't stop "${game.value.mName}"`,
+        description: `Drop failed to stop "${game.value.mName}": ${e}`,
+        buttonText: "Close",
+      },
+      (e, c) => c()
+    );
+    console.error(e);
+  }
+}
 </script>
diff --git a/desktop/src-tauri/Cargo.lock b/desktop/src-tauri/Cargo.lock
index 2d65c420..ff389434 100644
--- a/desktop/src-tauri/Cargo.lock
+++ b/desktop/src-tauri/Cargo.lock
@@ -987,6 +987,7 @@ dependencies = [
  "serde",
  "serde-binary",
  "serde_json",
+ "shared_child",
  "tauri",
  "tauri-build",
  "tauri-plugin-deep-link",
diff --git a/desktop/src-tauri/Cargo.toml b/desktop/src-tauri/Cargo.toml
index 1b843216..e8bc0707 100644
--- a/desktop/src-tauri/Cargo.toml
+++ b/desktop/src-tauri/Cargo.toml
@@ -44,6 +44,7 @@ chrono = "0.4.38"
 tauri-plugin-os = "2"
 boxcar = "0.2.7"
 umu-wrapper-lib = "0.1.0"
+shared_child = "1.0.1"
 
 [dependencies.tauri]
 version = "2.1.1"
diff --git a/desktop/src-tauri/src/process/process_commands.rs b/desktop/src-tauri/src/process/process_commands.rs
index afdd3089..74d7dfd6 100644
--- a/desktop/src-tauri/src/process/process_commands.rs
+++ b/desktop/src-tauri/src/process/process_commands.rs
@@ -25,5 +25,5 @@ pub fn kill_game(
 ) -> Result<(), String> {
     let state_lock = state.lock().unwrap();
     let mut process_manager_lock = state_lock.process_manager.lock().unwrap();
-    process_manager_lock.terminate_child(game_id).map_err(|x| x.to_string())
+    process_manager_lock.kill_game(game_id).map_err(|x| x.to_string())
 }
\ No newline at end of file
diff --git a/desktop/src-tauri/src/process/process_manager.rs b/desktop/src-tauri/src/process/process_manager.rs
index 57b748ae..ccab03d8 100644
--- a/desktop/src-tauri/src/process/process_manager.rs
+++ b/desktop/src-tauri/src/process/process_manager.rs
@@ -1,9 +1,16 @@
 use std::{
-    collections::HashMap, fs::{File, OpenOptions}, io, path::{Path, PathBuf}, process::{Child, Command, ExitStatus}, sync::{Arc, Mutex}, thread::spawn
+    collections::HashMap,
+    fs::{File, OpenOptions},
+    io,
+    path::{Path, PathBuf},
+    process::{Child, Command, ExitStatus},
+    sync::{Arc, Mutex},
+    thread::spawn,
 };
 
 use log::{info, warn};
 use serde::{Deserialize, Serialize};
+use shared_child::SharedChild;
 use tauri::{AppHandle, Manager};
 use umu_wrapper_lib::command_builder::UmuCommandBuilder;
 
@@ -17,7 +24,7 @@ use crate::{
 pub struct ProcessManager<'a> {
     current_platform: Platform,
     log_output_dir: PathBuf,
-    processes: HashMap<String, Arc<Mutex<Child>>>,
+    processes: HashMap<String, Arc<SharedChild>>,
     app_handle: AppHandle,
     game_launchers: HashMap<(Platform, Platform), &'a (dyn ProcessHandler + Sync + Send + 'static)>,
 }
@@ -75,14 +82,18 @@ impl ProcessManager<'_> {
          */
         (absolute_exe, Vec::new())
     }
-    pub fn terminate_child(&mut self, game_id: String) -> Result<(), io::Error> {
+    pub fn kill_game(&mut self, game_id: String) -> Result<(), io::Error> {
         return match self.processes.get(&game_id) {
             Some(child) => {
-                let mut lock = child.lock().unwrap();
-                lock.kill()
+                child.kill()?;
+                child.wait()?;
+                Ok(())
             },
-            None => Err(io::Error::new(io::ErrorKind::NotFound, "Game ID not running")),
-        }
+            None => Err(io::Error::new(
+                io::ErrorKind::NotFound,
+                "Game ID not running",
+            )),
+        };
     }
 
     fn on_process_finish(&mut self, game_id: String, result: Result<ExitStatus, std::io::Error>) {
@@ -123,6 +134,8 @@ impl ProcessManager<'_> {
         let status = GameStatusManager::fetch_state(&game_id);
 
         push_game_update(&self.app_handle, game_id.clone(), status);
+
+        // TODO better management
     }
 
     pub fn valid_platform(&self, platform: &Platform) -> Result<bool, String> {
@@ -235,7 +248,8 @@ impl ProcessManager<'_> {
             error_file,
         )?;
 
-        let launch_process_handle = Arc::new(Mutex::new(launch_process));
+        let launch_process_handle =
+            Arc::new(SharedChild::new(launch_process).map_err(|e| e.to_string())?);
 
         db_lock
             .games
@@ -253,8 +267,7 @@ impl ProcessManager<'_> {
         let wait_thread_game_id = game_id.clone();
 
         spawn(move || {
-            let mut child_handle = wait_thread_handle.lock().unwrap();
-            let result: Result<ExitStatus, std::io::Error> = child_handle.wait();
+            let result: Result<ExitStatus, std::io::Error> = launch_process_handle.wait();
 
             let app_state = wait_thread_apphandle.state::<Mutex<AppState>>();
             let app_state_handle = app_state.lock().unwrap();
@@ -266,10 +279,9 @@ impl ProcessManager<'_> {
             // But just to explicit about it
             drop(process_manager_handle);
             drop(app_state_handle);
-            drop(child_handle);
         });
 
-        self.processes.insert(game_id, launch_process_handle);
+        self.processes.insert(game_id, wait_thread_handle);
 
         info!("finished spawning process");