From 1356d91423f98b53a77b484d9b66cd69db350573 Mon Sep 17 00:00:00 2001 From: Skylot Date: Sun, 18 Mar 2018 13:34:32 +0300 Subject: [PATCH] res: don't add colon for empty namespace (#231) --- .../src/main/java/jadx/core/xmlgen/BinaryXMLParser.java | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/jadx-core/src/main/java/jadx/core/xmlgen/BinaryXMLParser.java b/jadx-core/src/main/java/jadx/core/xmlgen/BinaryXMLParser.java index cd430155a..e12d1314c 100644 --- a/jadx-core/src/main/java/jadx/core/xmlgen/BinaryXMLParser.java +++ b/jadx-core/src/main/java/jadx/core/xmlgen/BinaryXMLParser.java @@ -250,7 +250,13 @@ public class BinaryXMLParser extends CommonBinaryParser { int styleIndex = is.readInt16(); if ("manifest".equals(currentTag) || writer.getIndent() == 0) { for (Map.Entry entry : nsMap.entrySet()) { - writer.add(" xmlns:" + entry.getValue() + "=\"").add(entry.getKey()).add("\""); + String nsValue = entry.getValue(); + writer.add(" xmlns"); + if (nsValue != null && !nsValue.trim().isEmpty()) { + writer.add(':'); + writer.add(nsValue); + } + writer.add("=\"").add(entry.getKey()).add("\""); } } boolean attrNewLine = attributeCount != 1 && ATTR_NEW_LINE;