From 1ad6527de57e1ec47f1f711124eb6b81d220bc26 Mon Sep 17 00:00:00 2001 From: nitram84 <58364572+nitram84@users.noreply.github.com> Date: Mon, 10 Apr 2023 19:34:17 +0200 Subject: [PATCH] fix(xml): use parent attibute only for styles (PR #1815) --- .../src/main/java/jadx/core/xmlgen/ResXmlGen.java | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/jadx-core/src/main/java/jadx/core/xmlgen/ResXmlGen.java b/jadx-core/src/main/java/jadx/core/xmlgen/ResXmlGen.java index b09f91166..5d8556f2c 100644 --- a/jadx-core/src/main/java/jadx/core/xmlgen/ResXmlGen.java +++ b/jadx-core/src/main/java/jadx/core/xmlgen/ResXmlGen.java @@ -123,14 +123,15 @@ public class ResXmlGen { if (formatValue != null) { cw.add("\" format=\"").add(formatValue); } - cw.add("\""); } else { - cw.add(ri.getKeyName()).add('\"'); + cw.add(ri.getKeyName()); } - cw.add(" parent=\""); - if (ri.getParentRef() != 0) { - String parent = vp.decodeValue(TYPE_REFERENCE, ri.getParentRef()); - cw.add(parent); + if (ri.getTypeName().equals("style") || ri.getParentRef() != 0) { + cw.add("\" parent=\""); + if (ri.getParentRef() != 0) { + String parent = vp.decodeValue(TYPE_REFERENCE, ri.getParentRef()); + cw.add(parent); + } } cw.add("\">");