From 1ce8fa8bdd4f3cf14206d7f5675b6c7e07ef7e08 Mon Sep 17 00:00:00 2001 From: Skylot Date: Tue, 28 Jan 2020 20:07:58 +0000 Subject: [PATCH] fix: don't apply types if search failed (#840) --- .../jadx/core/dex/visitors/typeinference/TypeSearch.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/jadx-core/src/main/java/jadx/core/dex/visitors/typeinference/TypeSearch.java b/jadx-core/src/main/java/jadx/core/dex/visitors/typeinference/TypeSearch.java index ab5517339..bd8e7873d 100644 --- a/jadx-core/src/main/java/jadx/core/dex/visitors/typeinference/TypeSearch.java +++ b/jadx-core/src/main/java/jadx/core/dex/visitors/typeinference/TypeSearch.java @@ -67,9 +67,10 @@ public class TypeSearch { LOG.warn("Multi-variable search failed in {}", mth); } } - - boolean applySuccess = applyResolvedVars(); - return searchSuccess && applySuccess; + if (searchSuccess) { + return applyResolvedVars(); + } + return false; } private boolean applyResolvedVars() {