From 1ec041a48f8e9b8e3cb6562be8565103844cbe88 Mon Sep 17 00:00:00 2001 From: Felix Bergmann Date: Mon, 30 Jul 2018 00:09:54 +0200 Subject: [PATCH] Directory Bug The correct pattern to make a directory is: `if (!dir.mkdirs() && !dir.isDirectory()) { error }` mkdirs checks for exists so the exists check is redundant. --- jadx-core/src/main/java/jadx/core/utils/files/FileUtils.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jadx-core/src/main/java/jadx/core/utils/files/FileUtils.java b/jadx-core/src/main/java/jadx/core/utils/files/FileUtils.java index d117bc88c..fa523eb7c 100644 --- a/jadx-core/src/main/java/jadx/core/utils/files/FileUtils.java +++ b/jadx-core/src/main/java/jadx/core/utils/files/FileUtils.java @@ -57,7 +57,7 @@ public class FileUtils { public static void makeDirs(@Nullable File dir) { if (dir != null) { synchronized (MKDIR_SYNC) { - if (!dir.exists() && !dir.mkdirs()) { + if (!dir.mkdirs() && !dir.isDirectory()) { throw new JadxRuntimeException("Can't create directory " + dir); } }