From d06ba95374ed2dfdc828867319fb2e9303ace9c1 Mon Sep 17 00:00:00 2001
From: Skylot <skylot@gmail.com>
Date: Mon, 26 Oct 2020 11:15:25 +0000
Subject: [PATCH] chore: remove unused static strings array

---
 .../src/main/java/jadx/core/xmlgen/entry/ValuesParser.java   | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/jadx-core/src/main/java/jadx/core/xmlgen/entry/ValuesParser.java b/jadx-core/src/main/java/jadx/core/xmlgen/entry/ValuesParser.java
index cdd9c73d2..f0bdc541b 100644
--- a/jadx-core/src/main/java/jadx/core/xmlgen/entry/ValuesParser.java
+++ b/jadx-core/src/main/java/jadx/core/xmlgen/entry/ValuesParser.java
@@ -20,7 +20,6 @@ import jadx.core.xmlgen.ResTableParser;
 public class ValuesParser extends ParserConstants {
 	private static final Logger LOG = LoggerFactory.getLogger(ValuesParser.class);
 
-	private static String[] androidStrings;
 	private static Map<Integer, String> androidResMap;
 
 	private final String[] strings;
@@ -30,7 +29,7 @@ public class ValuesParser extends ParserConstants {
 		this.strings = strings;
 		this.resMap = resMap;
 
-		if (androidStrings == null && androidResMap == null) {
+		if (androidResMap == null) {
 			try {
 				decodeAndroid(root);
 			} catch (Exception e) {
@@ -39,11 +38,11 @@ public class ValuesParser extends ParserConstants {
 		}
 	}
 
+	// TODO: store only needed data instead full resources.arsc file
 	private static void decodeAndroid(RootNode root) throws IOException {
 		try (InputStream inputStream = new BufferedInputStream(ValuesParser.class.getResourceAsStream("/resources.arsc"))) {
 			ResTableParser androidParser = new ResTableParser(root);
 			androidParser.decode(inputStream);
-			androidStrings = androidParser.getStrings();
 			androidResMap = androidParser.getResStorage().getResourcesNames();
 		}
 	}