jessikitty/jadx
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: resolve LGTM alerts (PR #1162)

Browse Source 
* fix LGTM alerts
* Update jadx-gui/src/main/java/jadx/gui/device/debugger/BreakpointManager.java
* Update Smali.java

Co-authored-by: tobias <tobias.hotmail.com>
Co-authored-by: skylot <118523+skylot@users.noreply.github.com>
This commit is contained in:
LBJ-the-GOAT
2021-04-26 04:55:47 +08:00
committed by GitHub
parent bfc343d1ee
commit 8dad158ae6
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
jadx-gui/src/main/java/jadx/gui/device/debugger/BreakpointManager.java
+1 -1
View File
@@ -166,7 +166,7 @@ public class BreakpointManager {
@Override
public int hashCode() {
return (int) (31 * codeOffset + 31 * cls.hashCode() + 31 * mth.hashCode());
return Objects.hash(codeOffset, cls, mth);
}
@Override
jadx-gui/src/main/java/jadx/gui/device/debugger/smali/Smali.java
+2 -2
View File
@@ -660,8 +660,8 @@ public class Smali {
private void formatByteCode(StringBuilder smali, byte[] bytes) {
int maxLen = Math.min(bytes.length, 4 * 2); // limit to 4 units
StringBuilder inHex = new StringBuilder();
for (int i = 0; i < maxLen; i++) {
int temp = ((bytes[i++] & 0xff) << 8) | (bytes[i] & 0xff);
for (int i = 0; i < maxLen - 1; i += 2) {
int temp = ((bytes[i] & 0xff) << 8) | (bytes[i + 1] & 0xff);
inHex.append(String.format("%04x ", temp));
}
smali.append(String.format(FMT_BYTECODE_COL, inHex));