jessikitty
f7c20de5ac
LIM configured no logging at all, so the instruction fetcher had no trail to follow. Adds a rotating file handler on the root logger plus two owner-only admin pages. - Admin > Logs: filter by level, source and text; tracebacks kept with their error; auto-refresh, raw download, rotated-file browsing and rotate-now - Admin > Logs > Brickset API calls: every outbound call recorded with method, params, caller, duration, result count and error, plus daily quota accounting (only getSets counts) and a comparison against getKeyUsageStats - New owner concept (services/ownership.py): a single account, distinct from is_admin, since these pages expose other admins activity. Defaults to the first admin; flask owner show/set to change - Services now log through module loggers; retention setting and pruning for call records - New CLI: flask owner show/set, flask logs path/prune - New table brickset_api_calls, created automatically at boot; LOG_* env vars, /data/logs in Docker
86 lines
3.4 KiB
Python
86 lines
3.4 KiB
Python
"""
|
|
Lightweight, idempotent schema top-ups.
|
|
|
|
`db.create_all()` creates missing tables but never alters existing ones, so a
|
|
new column on an existing table needs help. This adds only what's missing and
|
|
is safe to run on every boot, on both SQLite and Postgres.
|
|
|
|
It is not a replacement for real migrations — it handles additive column
|
|
changes, which is all LIM has needed so far.
|
|
|
|
Created by: Jess Rogerson (yelling commands at Claude.AI)
|
|
"""
|
|
|
|
from sqlalchemy import inspect, text
|
|
|
|
from app import db
|
|
|
|
# table -> column -> DDL fragment used in ALTER TABLE ... ADD COLUMN
|
|
ADDITIVE_COLUMNS = {
|
|
'sets': {
|
|
# Existing rows keep the behaviour they had before visibility existed:
|
|
# everyone could see every set, so they become 'public' rather than
|
|
# silently vanishing from other users' libraries. New sets use the
|
|
# site default instead.
|
|
'visibility': "VARCHAR(10) NOT NULL DEFAULT 'public'",
|
|
},
|
|
'instructions': {
|
|
# Written by the automatic fetcher; null on everything uploaded
|
|
# before it existed, which is fine - dedupe just can't help there.
|
|
'sha256': 'VARCHAR(64)',
|
|
'source': 'VARCHAR(20)',
|
|
},
|
|
}
|
|
|
|
# Tables added by later versions. create_all() is not called at boot, so new
|
|
# tables need an explicit (and idempotent) nudge.
|
|
NEW_TABLES = (
|
|
'app.models.instruction_fetch.InstructionFetchJob',
|
|
'app.models.api_call.BricksetApiCall',
|
|
)
|
|
|
|
|
|
def ensure_schema(app):
|
|
"""Add any missing columns. Returns a list of changes made."""
|
|
applied = []
|
|
with app.app_context():
|
|
try:
|
|
inspector = inspect(db.engine)
|
|
existing_tables = set(inspector.get_table_names())
|
|
except Exception as exc: # database not reachable yet
|
|
app.logger.warning('Schema check skipped: %s', exc)
|
|
return applied
|
|
|
|
for dotted in NEW_TABLES:
|
|
module_path, _, class_name = dotted.rpartition('.')
|
|
try:
|
|
module = __import__(module_path, fromlist=[class_name])
|
|
model = getattr(module, class_name)
|
|
if model.__tablename__ not in existing_tables:
|
|
model.__table__.create(db.engine, checkfirst=True)
|
|
applied.append(f'table {model.__tablename__}')
|
|
app.logger.info('Schema upgrade: created table %s',
|
|
model.__tablename__)
|
|
except Exception as exc:
|
|
app.logger.error('Schema upgrade failed for %s: %s',
|
|
dotted, exc)
|
|
|
|
for table, columns in ADDITIVE_COLUMNS.items():
|
|
if table not in existing_tables:
|
|
continue # create_all() will build it with everything present
|
|
present = {c['name'] for c in inspector.get_columns(table)}
|
|
for column, ddl in columns.items():
|
|
if column in present:
|
|
continue
|
|
statement = f'ALTER TABLE {table} ADD COLUMN {column} {ddl}'
|
|
try:
|
|
with db.engine.begin() as conn:
|
|
conn.execute(text(statement))
|
|
applied.append(f'{table}.{column}')
|
|
app.logger.info('Schema upgrade: added %s.%s', table, column)
|
|
except Exception as exc:
|
|
app.logger.error('Schema upgrade failed for %s.%s: %s',
|
|
table, column, exc)
|
|
|
|
return applied
|