jessikitty/jadx
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(gui): improve accessibility of preferences dialog (#2445)

Browse Source
This commit is contained in:
Skylot
2025-03-17 21:25:59 +00:00
parent a163e5a1de
commit b4f1021885
3 changed files with 13 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
jadx-gui/src/main/java/jadx/gui/settings/ui/JadxSettingsWindow.java
+1
View File
@@ -142,6 +142,7 @@ public class JadxSettingsWindow extends JDialog {
tree = new SettingsTree();
tree.init(wrapGroupPanel, groups);
tree.setFocusable(true);
JScrollPane leftPane = new JScrollPane(tree);
leftPane.setBorder(BorderFactory.createEmptyBorder(10, 10, 3, 3));
jadx-gui/src/main/java/jadx/gui/settings/ui/SettingsGroup.java
+9 -5
View File
@@ -39,10 +39,18 @@ public class SettingsGroup implements ISettingsGroup {
}
public JLabel addRow(String label, String tooltip, JComponent comp) {
c.gridy = row++;
JLabel rowLbl = new JLabel(label);
rowLbl.setLabelFor(comp);
rowLbl.setHorizontalAlignment(SwingConstants.LEFT);
if (tooltip != null) {
rowLbl.setToolTipText(tooltip);
comp.setToolTipText(tooltip);
} else {
comp.setToolTipText(label);
}
comp.getAccessibleContext().setAccessibleName(label);
c.gridy = row++;
c.gridx = 0;
c.gridwidth = 1;
c.anchor = GridBagConstraints.LINE_START;
@@ -55,10 +63,6 @@ public class SettingsGroup implements ISettingsGroup {
c.weightx = 0.7;
c.fill = GridBagConstraints.LINE_START;
if (tooltip != null) {
rowLbl.setToolTipText(tooltip);
comp.setToolTipText(tooltip);
}
gridPanel.add(comp, c);
comp.addPropertyChangeListener("enabled", evt -> rowLbl.setEnabled((boolean) evt.getNewValue()));
return rowLbl;
jadx-gui/src/main/java/jadx/gui/settings/ui/plugins/PluginSettingsGroup.java
+3 -2
View File
@@ -96,6 +96,7 @@ class PluginSettingsGroup implements ISettingsGroup {
pluginList.setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
pluginList.setCellRenderer(new PluginsListCellRenderer());
pluginList.addListSelectionListener(ev -> onSelection(pluginList.getSelectedValue()));
pluginList.setFocusable(true);
JScrollPane scrollPane = new JScrollPane(pluginList);
scrollPane.setMinimumSize(new Dimension(80, 120));
@@ -276,8 +277,7 @@ class PluginSettingsGroup implements ISettingsGroup {
titleLbl = new JLabel();
titleLbl.setHorizontalAlignment(SwingConstants.CENTER);
titleLbl.setEnabled(false);
versionLbl.setPreferredSize(new Dimension(40, 10));
titleLbl.setPreferredSize(new Dimension(40, 10));
}
@Override
@@ -290,6 +290,7 @@ class PluginSettingsGroup implements ISettingsGroup {
nameLbl.setText(plugin.getTitle());
nameLbl.setToolTipText(plugin.getLocationId());
versionLbl.setText(Utils.getOrElse(plugin.getVersion(), ""));
panel.getAccessibleContext().setAccessibleName(plugin.getTitle());
boolean enabled = !plugin.isDisabled();
nameLbl.setEnabled(enabled);